Skip to content

hack: stop extraction at footer in moby-sync-release.sh#24468

Closed
Himanshu2459 wants to merge 1 commit intodocker:mainfrom
Himanshu2459:main
Closed

hack: stop extraction at footer in moby-sync-release.sh#24468
Himanshu2459 wants to merge 1 commit intodocker:mainfrom
Himanshu2459:main

Conversation

@Himanshu2459
Copy link
Copy Markdown

@Himanshu2459 Himanshu2459 commented Mar 22, 2026

Description

Related issues or tickets

Reviews

  • Technical review
  • Editorial review
  • Product review

@netlify
Copy link
Copy Markdown

netlify bot commented Mar 22, 2026

Deploy Preview for docsdocker ready!

Name Link
🔨 Latest commit f9c7998
🔍 Latest deploy log https://app.netlify.com/projects/docsdocker/deploys/69bfe07ff04d1c00083e9fda
😎 Deploy Preview https://deploy-preview-24468--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@thaJeztah thaJeztah requested a review from vvoland March 27, 2026 13:30
@vvoland
Copy link
Copy Markdown
Contributor

vvoland commented Mar 27, 2026

Curious, what's your use case for this script?

@Himanshu2459
Copy link
Copy Markdown
Author

I don't use this script myself — I spotted #24533 and traced the 404 to the autogenerated footer not being stripped during extraction. This just adds a sed to cut everything from --- onwards so only the actual notes get pulled in.

@dvdksn
Copy link
Copy Markdown
Contributor

dvdksn commented Apr 1, 2026

Claude thinks this is incorrect. The --- thematic break in the 29.0.0 section isn't causing a problem here. The real issue is that the grep -m 2 -B 10000 '^## ' extraction logic relies on finding two ## headings (the target version and the next one). For the last version in a file there's no second heading, so the pipeline produces 0 lines of output — regardless of the ---.

Additionally, the proposed sed '/^---$/,$d' would be harmful if the extraction were fixed: it would delete from the --- to the end, dropping the ### New, ### Bug fixes and enhancements, and all other subsections after the thematic break in the 29.0.0 section.

@dvdksn dvdksn closed this Apr 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants